Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥅 show THI backend error #336

Merged

Conversation

BuildmodeOne
Copy link
Member

@BuildmodeOne BuildmodeOne commented Oct 6, 2023

localhost_3000_login_(iPhone 12 Pro) (1)

For now, simple method to show backend error of THI to show the user that the error does not occur from the part of Neuland.

🤖 Generated by Copilot at 0a26563

Summary

🌐🐛🚧

Improved login error handling and feedback for the rogue-thi-app. Added a new error.backend string to the translation files login.json for German and English.

Oh we are the coders of the sea
And we work on the login screen
We add error.backend to the files
So the users know what's wrong when it fails

Walkthrough

  • Add constant array KNOWN_BACKEND_ERRORS to store error messages from THI backend (link)
  • Modify login function to catch and log errors during login process (link)
    • Set failure state to error.backend if error message matches any of the KNOWN_BACKEND_ERRORS (link)
    • Set failure state to error.generic otherwise (link)
  • Update German and English translation files to include new string error.backend with corresponding message (link, link)

@BuildmodeOne BuildmodeOne merged commit 2a8b4e6 into neuland-ingolstadt:develop Oct 6, 2023
4 checks passed
@BuildmodeOne BuildmodeOne deleted the backend-error branch October 6, 2023 19:41
@Robert27 Robert27 linked an issue Oct 25, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when backend is down
2 participants