Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨🐛 rework room map and fix theme bugs #326

Merged
merged 11 commits into from
Oct 2, 2023

Conversation

BuildmodeOne
Copy link
Member

@BuildmodeOne BuildmodeOne commented Sep 29, 2023

🤖 Generated by Copilot at bfb7c3a

Summary

🐛🎨🧹

This pull request fixes a color bug for special rooms on the map and refactors the CSS styles to use variables. It changes the pathOptions prop logic in RoomMap.jsx and the color values in RoomMap.module.css.

Walkthrough

  • Fix bug where special rooms would not have correct color when available (link)
  • Use CSS variables for background colors of special and occupied rooms (link, link)
Missing theme with theme
image image
Old design New design (light) New design (dark)
dev neuland app_rooms_(iPhone 12 Pro) localhost_3000_personal_(iPhone 12 Pro) localhost_3000_rooms_(iPhone 12 Pro) (1)

@BuildmodeOne BuildmodeOne changed the title 🐛 render special rooms in special color and adjust legend to theme 🎨🐛 rework room map and theme bugs Sep 30, 2023
@BuildmodeOne BuildmodeOne changed the title 🎨🐛 rework room map and theme bugs 🎨🐛 rework room map and fix theme bugs Oct 1, 2023
@BuildmodeOne BuildmodeOne merged commit 8763975 into neuland-ingolstadt:develop Oct 2, 2023
@BuildmodeOne BuildmodeOne deleted the map-styling branch October 2, 2023 19:57
alexhorn pushed a commit that referenced this pull request Oct 4, 2023
* 🐛 render special rooms in special color and adjust legend to theme

* 🎨 unify TUX_ROOMS

* 🐛 fix special room indicator in room map popup

* 🎨 load common.scss in every theme

* 💄 style room map Popup

* 🐛 fix Theme indicator showing light and thi-light

* 🐛 fix popup close button position

* 💄 rework room map

* 🐛 fix light themes

* 💄 location marker in theme color

* 🐛 more theme fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants