🐛 Fix timetable errors during semester break (#320)

neuland-ingolstadt · Aug 2, 2023 · 27f9aeb · 27f9aeb
1 parent 2801b9e
commit 27f9aeb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/rogue-thi-app/components/cards/TimetableCard.jsx b/rogue-thi-app/components/cards/TimetableCard.jsx
@@ -82,11 +82,13 @@ export default function TimetableCard () {
             )
           }))}
           {(timetable && timetable.length === 0) &&
-              <ListGroup.Item>{t('timetable.text.noLectures')}</ListGroup.Item>
+            <ListGroup.Item>
+              {t('timetable.text.noLectures')}
+            </ListGroup.Item>
           }
           {(timetableError &&
-              <ListGroup.Item>{t('timetable.text.error')}</ListGroup.Item>)
-          }
+            <ListGroup.Item>{t('timetable.text.error')}</ListGroup.Item>
+          )}
         </ListGroup>
       </ReactPlaceholder>
     </BaseCard>

diff --git a/rogue-thi-app/lib/backend-utils/timetable-utils.js b/rogue-thi-app/lib/backend-utils/timetable-utils.js
@@ -76,6 +76,15 @@ export function getTimetableGaps (timetable) {
 export async function getFriendlyTimetable (date, detailed) {
   const { timetable } = await API.getTimetable(date, detailed)
 
+  /**
+   * During the semester break, the API returns an null array ('[null]').
+   * To prevent errors for the room suggestions or the timetable view, we return an empty array.
+   */
+  if (timetable.every(x => x === null)) {
+    console.error('API returned null array for timetable!')
+    return []
+  }
+
   return timetable
     .flatMap(day =>
       Object.values(day.hours)