Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight submit system button #521

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Conversation

qjiang002
Copy link
Collaborator

This PR is related to issue #516

If the user hasn't logged in, they will see System page like this. The tooltip is default visible. User can click either 'Log in' button or 'Submit New System' button to log in.

Screen Shot 2022-11-17 at 2 30 15 PM

If the user has logged in, they will see System page like this.

Screen Shot 2022-11-17 at 2 30 36 PM

@lyuyangh
Copy link
Member

Thanks, @qjiang002 !

I like how you made the "New" button more visible by making it bigger. I think we should maybe reserve danger (red) buttons for operations that are risky and less frequently used (e.g. delete) though. This is also what antd suggests (doc). WDYT?

@qjiang002
Copy link
Collaborator Author

Thanks @lyuyangh . I change the color to 'call-to-action' (green) as suggested in the doc.

Screen Shot 2022-11-17 at 4 02 04 PM

Screen Shot 2022-11-17 at 4 02 23 PM

Copy link
Member

@lyuyangh lyuyangh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qjiang002 qjiang002 merged commit 8d28c4b into main Nov 18, 2022
@qjiang002 qjiang002 deleted the refactor-submit-system-button branch November 18, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants