Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Development Only Scripts template #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rasmizzle
Copy link
Contributor

Feature:

  • Added Networkteam.Neos.Vite:Helper.DevelopmentOnlyScripts for including scripts in development context only.
  • Added Networkteam.Neos.Vite:Helper.IsDevelopmentOnly as a boolean check if inside development context.
  • Added Networkteam.Neos.Vite:Head.Assets for head-scripts, including react-refresh-runtime, which is needed for any react-base development.
    • this is a philosophical question whether we want to auto include it here...? I'd say there is nothing wrong with it, as most of the time users of this package use react; it is only included in dev-context.
  • Added Networkteam.Neos.Vite:Body.Assets for wrapping projects body scripts.

I'd like some feedback whether this is a valid approach or if one rather wants to leave more configuration to the customer project.

@Rasmizzle Rasmizzle requested a review from hlubek June 25, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant