Feature/allow imgproxy url modification #11
Conversation
… additional processing options
…ncy of modifier class
|
Hello there, Do you have an first opinion if this will make it into your package soon or at all? Regards, |
| @@ -76,4 +76,9 @@ public function cacheBuster(string $cacheBuster) | |||
| { | |||
| $this->processingOptions[] = 'cb:' . $cacheBuster; | |||
| } | |||
|
|
|||
| public function addProcessingOption($key, $value) | |||
There was a problem hiding this comment.
$key can be type-hinted with string
| ## How to modify the imgproxy url | ||
| If you need to modify the imgproxy url for your custom needs you can use the following hook: | ||
| 1. Create a modifier class in this format: | ||
| ``` |
There was a problem hiding this comment.
Add php here and <?php in the next line
| } | ||
| ``` | ||
| 2. Register your modifier in the settings: | ||
| ``` |
| @@ -109,6 +109,15 @@ public function generateImgproxyUri(JoinPointInterface $joinPoint): ?array | |||
|
|
|||
| $expectedSize = ImgproxyBuilder::expectedSize($actualDimension, $targetDimension, $resizingType, $enlarge); | |||
|
|
|||
| foreach ($this->settings['imgproxyUrlModifiers'] as $modifierClassName){ | |||
| if(class_exists($modifierClassName)){ | |||
There was a problem hiding this comment.
IMHO class_exists() and is_callable() should be removed here. When class does not exist or isn't callable, then i prefer to get an Exception and to know i made a mistake.
| { | ||
| public function __invoke(ImgproxyUrl $url, ThumbnailConfiguration $configuration): void | ||
| { | ||
| // modify the ImgproxyUrl object |
There was a problem hiding this comment.
Add call to the new function here? $url->addProcessingOption('auto_rotate', 1)
|
@rtp-cgs Hi there! Thx for the PR and great to hear that the package is useful for you. I looked at the code and would suggest a little different approach here: we could provide an interface for an Maybe we could also use settings for some standard cases like processing options (e.g. |
|
Hello @hlubek Thanks for the fast response and review. I see why you suggest this approach, I would prepare a example matching your approach if that is okay for you? I am not sure what the idea with the |
|
Hey there Networkteam, Sorry for the radio silence I was on holidays the last weeks. As requested I created a different solution in this branch / pull request: #12 |
This allows to modify the imgproxyUrl before it gets returned. I also added a general method to add custom processing options to the ImgproxyUrl object.
I added a hook functionality since a proper signal doesn't work because the ThumbnailAspect class is an AOP aspect.
If you have any feedback please let me know.
Regards,
Cyrill