This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
fix: prevent netlify dev from attempting to recursively call itself
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI detects different framework commands in package.json, and will throw if it detects `netlify dev` in the default script while running `netlify dev` in order to avoid recursively calling itself. By removing the `netlify dev` from the `start` and `dev` scripts and adjusting the CLI logic to recognize `netlify dev:exec` as distinct from `netlify:dev`, we can get this project working as expected. Also updates package.json dependencies. see also: netlify#26 netlify/cli#1798
|
Deploy request for faunadb-example pending review. Review with commit ef53022 |
|
I am actually following up on testing for this (it doesn't seem to be working perfectly yet), but the draft is here if anyone wants to take a look at the issue! |
ctjlewis
force-pushed
the
cli-compat-updates
branch
from
ec1123a to
ef53022
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI detects different framework commands in package.json, and will throw if it detects
netlify devin the default script while runningnetlify devin order to avoid recursively calling itself.By removing the
netlify devfrom thestartanddevscripts and adjusting the CLI logic to recognizenetlify dev:execas distinct fromnetlify:dev, we can get this project working as expected.Also updates package.json dependencies.
see also:
#26
netlify/cli#1798