Support macOS #58
Open
Support macOS #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Support macOS
Motivation
It'll be good to support macOS because macOS supports Bluetooth.
It'll also help with testing.
Task Description
There are two changes:
ConnectionSerivce.connect():centralManager.validateState()failed when tested on macOS.I don't think testing the state as soon as we create the
CBCentralManagermakes sense.We should test the state in
centralManagerDidUpdateState()and we are doing it there already.AdvertisementErroroptional:I made it optional to call the error handler even on success.
We are doing the same in
ConnectionSerivce.connect()and it tells the app whether the advertisement succeeds.Also, updated
Package.swiftto support macOS.