Merge pull request #15 from netgen/NGSTACK-957-git-hooks-node-version…

…-error NGSTACK-957 read and output stderr from eslint and prettier
netgen · Dec 19, 2024 · 7aa2ebb · 7aa2ebb
2 parents 1c1f32c + d883e34
commit 7aa2ebb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/Action/JSLinter.php b/src/Action/JSLinter.php
@@ -13,6 +13,7 @@
 use function count;
 use function escapeshellarg;
 use function preg_match;
+use function sprintf;
 
 final class JSLinter extends Action
 {
@@ -44,9 +45,10 @@ protected function doExecute(Config $config, IO $io, Repository $repository, Con
 
             $result = $this->lintFile($file, $linterCommand, $linterOptions);
 
-            $io->write($result['output']);
-
-            if ($result['success'] !== true) {
+            if ($result['success'] === true) {
+                $io->write($result['output']);
+            } else {
+                $io->writeError(sprintf('<error>%s</error>', $result['error']));
                 $this->throwError($action, $io);
             }
         }
@@ -85,6 +87,7 @@ protected function lintFile(string $file, string $linterCommand, string $linterO
         return [
             'success' => $result->isSuccessful(),
             'output' => $result->getStdOut(),
+            'error' => $result->getStdErr(),
         ];
     }
 }
diff --git a/src/Action/JSPrettier.php b/src/Action/JSPrettier.php
@@ -13,6 +13,7 @@
 use function count;
 use function escapeshellarg;
 use function preg_match;
+use function sprintf;
 
 final class JSPrettier extends Action
 {
@@ -44,9 +45,10 @@ protected function doExecute(Config $config, IO $io, Repository $repository, Con
 
             $result = $this->lintFile($file, $prettierCommand, $prettierOptions);
 
-            $io->write($result['output']);
-
-            if ($result['success'] !== true) {
+            if ($result['success'] === true) {
+                $io->write($result['output']);
+            } else {
+                $io->writeError(sprintf('<error>%s</error>', $result['error']));
                 $this->throwError($action, $io);
             }
         }
@@ -85,6 +87,7 @@ protected function lintFile(string $file, string $prettierCommand, string $prett
         return [
             'success' => $result->isSuccessful(),
             'output' => $result->getStdOut(),
+            'error' => $result->getStdErr(),
         ];
     }
 }