-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 4 new FT's | GRE Int , Cellular Int, Cellular Controller, Cellular Profile #74
base: main
Are you sure you want to change the base?
Conversation
- add support for sdwan_cellular_controller_feature_template resource - add support for sdwan_cellular_cedge_profile_feature_template resource - add support for sdwan_cisco_vpn_interface_gre_feature_template resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdwan_vpn_interface_cellular_feature_template has bug in the provider that should be fixed before we release this
]) | ||
} | ||
|
||
resource "sdwan_vpn_interface_cellular_feature_template" "vpn_interface_cellular_feature_template" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing this I discovered a bug in provider. To reproduce:
- Create this resource using TF
- Go to UI, click Edit and Save. Nothing will happen, in console you will see an error "e.ip is undefined"
This is probably because the provider doesn't include the mandatory, non-configurable block in JSON payload that should look like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tzarski0
i opened a provider issue. CiscoDevNet/terraform-provider-sdwan#378
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fixed.
add features requested in
https://wwwin-github.cisco.com/netascode/nac-sdwan/issues/328
https://wwwin-github.cisco.com/netascode/nac-sdwan/issues/329
https://wwwin-github.cisco.com/netascode/nac-sdwan/issues/330
Note
I encountered an issue with the provider not supporting this feature being attached to a device template.
I encountered an issue with the provider not supporting value "hub" for tunnel_qos_mode in Cellular Interface
Provider fix was built and merged CiscoDevNet/terraform-provider-sdwan#377 and will be publicly available with 0.5.2 release https://registry.terraform.io/providers/CiscoDevNet/sdwan/latest