Added missing dependencies (#10)

netascode · Mar 9, 2024 · 6370205 · 6370205
1 parent 3491895
commit 6370205
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 14 deletions.
diff --git a/ise_device_admin.tf b/ise_device_admin.tf
@@ -49,7 +49,7 @@ resource "ise_device_admin_condition" "device_admin_condition" {
     }]
   }]
 
-  depends_on = [ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_allowed_protocols_tacacs" "allowed_protocols_tacacs" {
@@ -218,7 +218,7 @@ resource "ise_device_admin_policy_set" "device_admin_policy_set_0" {
   rank                      = each.value.rank
   children                  = each.value.children
 
-  depends_on = [ise_allowed_protocols_tacacs.allowed_protocols_tacacs, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_allowed_protocols_tacacs.allowed_protocols_tacacs, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_device_admin_policy_set" "device_admin_policy_set_1" {
@@ -240,7 +240,7 @@ resource "ise_device_admin_policy_set" "device_admin_policy_set_1" {
   rank                      = each.value.rank
   children                  = each.value.children
 
-  depends_on = [ise_device_admin_policy_set.device_admin_policy_set_0, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_device_admin_policy_set.device_admin_policy_set_0, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_device_admin_policy_set" "device_admin_policy_set_2" {
@@ -729,7 +729,7 @@ resource "ise_device_admin_authentication_rule" "device_admin_authentication_rul
   if_user_not_found         = each.value.if_user_not_found
   children                  = each.value.children
 
-  depends_on = [ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_device_admin_authentication_rule" "device_admin_authentication_rule_1" {
@@ -1264,7 +1264,7 @@ resource "ise_device_admin_authorization_rule" "device_admin_authorization_rule_
   command_sets              = each.value.command_sets
   children                  = each.value.children
 
-  depends_on = [ise_tacacs_profile.tacacs_profile, ise_tacacs_command_set.tacacs_command_set, time_sleep.device_admin_policy_object_wait, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_tacacs_profile.tacacs_profile, ise_tacacs_command_set.tacacs_command_set, time_sleep.device_admin_policy_object_wait, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_device_admin_authorization_rule" "device_admin_authorization_rule_1" {
@@ -1747,7 +1747,7 @@ resource "ise_device_admin_authorization_exception_rule" "device_admin_authoriza
   command_sets              = each.value.command_sets
   children                  = each.value.children
 
-  depends_on = [ise_tacacs_profile.tacacs_profile, ise_tacacs_command_set.tacacs_command_set, time_sleep.device_admin_policy_object_wait, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_tacacs_profile.tacacs_profile, ise_tacacs_command_set.tacacs_command_set, time_sleep.device_admin_policy_object_wait, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_device_admin_authorization_exception_rule" "device_admin_authorization_exception_rule_1" {
@@ -2206,7 +2206,7 @@ resource "ise_device_admin_authorization_global_exception_rule" "device_admin_au
   command_sets              = each.value.command_sets
   children                  = each.value.children
 
-  depends_on = [ise_tacacs_profile.tacacs_profile, ise_tacacs_command_set.tacacs_command_set, time_sleep.device_admin_policy_object_wait, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_tacacs_profile.tacacs_profile, ise_tacacs_command_set.tacacs_command_set, time_sleep.device_admin_policy_object_wait, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_device_admin_authorization_global_exception_rule" "device_admin_authorization_global_exception_rule_1" {

diff --git a/ise_identity_management.tf b/ise_identity_management.tf
@@ -21,6 +21,8 @@ resource "ise_internal_user" "internal_user" {
   identity_groups        = length(try(each.value.user_identity_groups, [])) > 0 ? join(",", [for i in try(each.value.user_identity_groups, []) : ise_user_identity_group.user_identity_group[i].id]) : null
   password_never_expires = try(each.value.password_never_expires, local.defaults.ise.identity_management.internal_users.password_never_expires, null)
   password_id_store      = try(each.value.password_id_store, local.defaults.ise.identity_management.internal_users.password_id_store, null)
+
+  depends_on = [ise_user_identity_group.user_identity_group]
 }
 
 locals {

diff --git a/ise_network_access.tf b/ise_network_access.tf
@@ -125,7 +125,7 @@ resource "ise_authorization_profile" "authorization_profile" {
     create_before_destroy = true
   }
 
-  depends_on = [ise_downloadable_acl.downloadable_acl, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_downloadable_acl.downloadable_acl, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 locals {
@@ -179,7 +179,7 @@ resource "ise_network_access_condition" "network_access_condition" {
     }]
   }]
 
-  depends_on = [ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_downloadable_acl" "downloadable_acl" {
@@ -331,7 +331,7 @@ resource "ise_network_access_policy_set" "network_access_policy_set_0" {
   rank                      = each.value.rank
   children                  = each.value.children
 
-  depends_on = [ise_authorization_profile.authorization_profile, ise_allowed_protocols.allowed_protocols, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_authorization_profile.authorization_profile, ise_allowed_protocols.allowed_protocols, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_network_access_policy_set" "network_access_policy_set_1" {
@@ -843,7 +843,7 @@ resource "ise_network_access_authentication_rule" "network_access_authentication
   if_user_not_found         = each.value.if_user_not_found
   children                  = each.value.children
 
-  depends_on = [ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_network_access_authentication_rule" "network_access_authentication_rule_1" {
@@ -1366,7 +1366,7 @@ resource "ise_network_access_authorization_rule" "network_access_authorization_r
   security_group            = each.value.security_group
   children                  = each.value.children
 
-  depends_on = [ise_authorization_profile.authorization_profile, ise_trustsec_security_group.trustsec_security_group, time_sleep.sgt_wait, ise_endpoint_identity_group.endpoint_identity_group, ise_user_identity_group.user_identity_group, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_authorization_profile.authorization_profile, ise_trustsec_security_group.trustsec_security_group, time_sleep.sgt_wait, ise_endpoint_identity_group.endpoint_identity_group, ise_user_identity_group.user_identity_group, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_network_access_authorization_rule" "network_access_authorization_rule_1" {
@@ -1849,7 +1849,7 @@ resource "ise_network_access_authorization_exception_rule" "network_access_autho
   security_group            = each.value.security_group
   children                  = each.value.children
 
-  depends_on = [ise_authorization_profile.authorization_profile, ise_trustsec_security_group.trustsec_security_group, time_sleep.sgt_wait, ise_endpoint_identity_group.endpoint_identity_group, ise_user_identity_group.user_identity_group, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_authorization_profile.authorization_profile, ise_trustsec_security_group.trustsec_security_group, time_sleep.sgt_wait, ise_endpoint_identity_group.endpoint_identity_group, ise_user_identity_group.user_identity_group, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_network_access_authorization_exception_rule" "network_access_authorization_exception_rule_1" {
@@ -2308,7 +2308,7 @@ resource "ise_network_access_authorization_global_exception_rule" "network_acces
   security_group            = each.value.security_group
   children                  = each.value.children
 
-  depends_on = [ise_authorization_profile.authorization_profile, ise_trustsec_security_group.trustsec_security_group, time_sleep.sgt_wait, ise_endpoint_identity_group.endpoint_identity_group, ise_user_identity_group.user_identity_group, ise_active_directory_add_groups.active_directory_groups]
+  depends_on = [ise_authorization_profile.authorization_profile, ise_trustsec_security_group.trustsec_security_group, time_sleep.sgt_wait, ise_endpoint_identity_group.endpoint_identity_group, ise_user_identity_group.user_identity_group, ise_network_device_group.network_device_group_5, ise_active_directory_add_groups.active_directory_groups]
 }
 
 resource "ise_network_access_authorization_global_exception_rule" "network_access_authorization_global_exception_rule_1" {