Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace custom merge logic with mergedeep.merge #262

Closed
wants to merge 0 commits into from

Conversation

mcparaf
Copy link
Contributor

@mcparaf mcparaf commented Aug 2, 2024

In yaml.py there is logic that is responsible for merging multiple yaml files in order to create a hierarchy of objects that would be then be validated using yamale. This logic enters an infinite loop for this subdict:

switch_link_aggregations:
  - switch_ports:
    - port_id: "7"
      serial: asd
    - port_id: "8"
      serial: qwe

I have replaced the custom merging logic with a call to an external tool (mergedeep) that deals with this case correctly.

@mcparaf mcparaf force-pushed the main branch 2 times, most recently from 5771b71 to b9f2d12 Compare August 2, 2024 08:56
@mcparaf mcparaf changed the title replace custom merge logic with mergedeep.merge draft: replace custom merge logic with mergedeep.merge Aug 2, 2024
@mcparaf mcparaf changed the title draft: replace custom merge logic with mergedeep.merge replace custom merge logic with mergedeep.merge Aug 5, 2024
@mcparaf mcparaf requested a review from danischm August 5, 2024 23:08
@mcparaf mcparaf closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant