-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/transactions #21
Conversation
- Requires paymentMethodToken to be implemented
- going to create separate PR for subscription creation
@@ -29,7 +29,6 @@ export default class BraintreeWebhookController { | |||
|
|||
async handle(@Req() request) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be formatted, i think !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no I've ran format on it. What's the problem? The decorator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah think I see now!
Pull Request Test Coverage Report for Build 85
💛 - Coveralls |
Signed-off-by: ashleigh <[email protected]>
Feel like I've introduced more issues than completed here. The goal of this PR was to implement the basic required sale, refund and find methods with types.
Newly created, related issues
Relating issues
I also added my Braintree credentials to travis. Feel like maybe I should mock the responses instead of making a call the braintree. It's likely that PR's from outside of this repo will fail because travis is making the call the braintree without the creds on the contributor's repo and not this one.