Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transactions #21

Merged
merged 10 commits into from
Nov 21, 2018
Merged

Feature/transactions #21

merged 10 commits into from
Nov 21, 2018

Conversation

bashleigh
Copy link
Contributor

@bashleigh bashleigh commented Nov 21, 2018

Feel like I've introduced more issues than completed here. The goal of this PR was to implement the basic required sale, refund and find methods with types.

Newly created, related issues

Relating issues

I also added my Braintree credentials to travis. Feel like maybe I should mock the responses instead of making a call the braintree. It's likely that PR's from outside of this repo will fail because travis is making the call the braintree without the creds on the contributor's repo and not this one.

@bashleigh bashleigh added the enhancement New feature or request label Nov 21, 2018
@bashleigh bashleigh self-assigned this Nov 21, 2018
@@ -29,7 +29,6 @@ export default class BraintreeWebhookController {

async handle(@Req() request) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be formatted, i think !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I've ran format on it. What's the problem? The decorator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah think I see now!

@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 85

  • 5 of 10 (50.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.3%) to 88.462%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/braintree.provider.ts 3 8 37.5%
Totals Coverage Status
Change from base Build 72: -2.3%
Covered Lines: 140
Relevant Lines: 149

💛 - Coveralls

@nestjsx nestjsx deleted a comment from coveralls Nov 21, 2018
@nestjsx nestjsx deleted a comment from coveralls Nov 21, 2018
@bashleigh bashleigh merged commit d3aa6fa into master Nov 21, 2018
@bashleigh bashleigh deleted the feature/transactions branch November 21, 2018 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants