Support for conda, venv or pyenv-virtualenv usage in cookiecutter
#207
+96
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caldwellst
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Overall, I think the workflow is great. Not a very complex change from the user side, and think it provides a lot of value for anyone who isn't wanting to use conda to actually be able to use the cookiecutter. Currently receiving an error from the makefile when trying to test it out, however. Will review again once resolved, but overall agree with the approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #199 by allowing cookiecutter to specify the virtual environment management solution and then providing template commands that generalise in the makefile meaning per-project the user can specify their preference and
make installwill automatically set it up in the same way.If I understand correctly, this would require a slight change to the workflow in that a user should specify which they want to use when initiating the cookiecutter / might also make sense to add this to the GitHub repo workflow.
Checklist: