Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to Ruff and pyproject.toml #204

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

HarrisonWilde
Copy link

Not quite passing all tests but have switched fully to ruff and as a result ditched most of the other config files.

I cannot for the life of me get all tests to pass, because of weird issues in the makefile I have begun to address (This also fixes #203), one of which is the bug in the conda-remove step but now I cannot get the pre-commit hooks and install to work at the same time, seems to be some issue with conda on my system.

Main things to discuss before full PR are:

  1. Resolving the issues w the tests (and we may want to add more at some point but for now these seem to work ok)
  2. How precisely we want to use Ruff, you can see that I have pretty much kept in line with the old ways with a few changes like standard line length (88 from 80) and fewer ignores + standard isort, etc.

Checklist:

  • Updated documentation
  • CI passes
  • Labelled PR major/minor/patch

…full to ruff and as a result ditched most of the other config files
@HarrisonWilde HarrisonWilde added bug Something isn't working enhancement New feature or request labels Dec 19, 2024
@HarrisonWilde HarrisonWilde self-assigned this Dec 19, 2024
@HarrisonWilde
Copy link
Author

Checks now pass here, but still not on my machine, would be good to figure this out as my setup is fairly standard iiuc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug in conda env initialisation in makefile
1 participant