Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing functions to add targeted rebates to bills #11

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

eglucas
Copy link
Contributor

@eglucas eglucas commented Oct 9, 2024

This code adds two new functions in the summary.py module.

  • transform_income_decile_elibiligity() to transform the ofgem archetype income decile tables to calculate the number of eligible households in the lowest X income deciles.
  • subsidisation_table() to process baseline scenario results tables to produce another results table with the bill values for eligibile/ineligible households for a given eligibility criteria and rebate value. At present, I've left the output dataframe in pivot table format, but am open for it to be melted into tidy format if you think that would be most useful.

In this PR, could you please:

  • Review the new functions code and flag any bugs, efficiency improvement opportunities, missing documentation.
  • Check that the functions work as expected, you can do this in the new notebook I've set up rebates_targeting_development.py.

Checklist:

  • I have refactored my code out from notebooks/
  • I have checked the code runs
  • I have tested the code
  • I have run pre-commit and addressed any issues not automatically fixed
  • I have merged any new changes from dev
  • I have documented the code
    • Major functions have docstrings
    • Appropriate information has been added to READMEs
  • I have explained this PR above
  • I have requested a code review

@eglucas eglucas requested a review from danlewis85 October 9, 2024 10:44
@eglucas eglucas self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant