Handle input containing division by zero better #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clinssen
force-pushed
the
handle_div_by_zero
branch
from
f8a7076 to
a2f5e21
Compare
clinssen
commented
Nov 21, 2024
|
Sadly, sympy 1.4 seems to not work well with newer Python versions (starting from 3.9). This is probably triggered now by fixing the bug where "Mul" was missing from the list of sympy operators. If #70 is merged, we can drop support for sympy 1.4 altogether. I would suggest to wait for that PR to be merged first. |
2 tasks
pnbabu
reviewed
Dec 10, 2024
| @@ -43,7 +43,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| with_gsl: ["0", "1"] | |||
| sympy_version: ["==1.4", ""] # empty string for "latest" | |||
| sympy_version: [""] # empty string for "latest" | |||
There was a problem hiding this comment.
Can we remove sympy_version altogether?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of numerical issues with the input, throw a user-friendly error, like: