Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add microcircuit rate verification comments #3180

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Add microcircuit rate verification comments #3180

merged 1 commit into from
Jun 21, 2024
+3 −0

Conversation

otcathatsya
Copy link
Contributor

Adjust comments to match ported delay fix in beNNch, see INM-6/beNNch-models#10

@gtrensch gtrensch added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Apr 19, 2024
@github-actions GitHub Actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Jun 18, 2024
@heplesser heplesser added this to the NEST 3.8 milestone Jun 20, 2024
@heplesser heplesser requested a review from jhnnsnk June 20, 2024 12:00
@heplesser
Copy link
Contributor

Single review suffices.

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Jun 21, 2024
jhnnsnk
jhnnsnk approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@jhnnsnk jhnnsnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this useful comment! 👍

@heplesser
Copy link
Contributor

Adjustment of comments only, therefore merging based on single review.

@heplesser heplesser merged commit e1a0c18 into nest:master Jun 21, 2024
24 checks passed
@otcathatsya otcathatsya deleted the mc_comment branch July 5, 2024 15:21
@BrewTestBot BrewTestBot mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhnnsnk jhnnsnk jhnnsnk approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST
Status: Done
Milestone
NEST 3.8
Development

Successfully merging this pull request may close these issues.
4 participants
@otcathatsya @heplesser @jhnnsnk @gtrensch