Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation will not preserve dots in usernames. For example, "john.doe" would be converted to "john-doe".
To modify the function to accept usernames with dots, we need to update the
NON_ALPHANUM_PATTERN
and possibly adjust theOBJECT_PATTERN
.key changes made:
LOWER_PLUS_HYPHEN
array.OBJECT_PATTERN
andLABEL_PATTERN
to include dot.NON_ALPHANUM_PATTERN
to allow dots:/[^a-z0-9\.]+/
didn't need to modify the
extract_safe_name
method itself because the changes toNON_ALPHANUM_PATTERN
are sufficient to preserve dots. ( I think)