add custom union id in ebnf definition #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval-exec
reviewed
Dec 28, 2023
docs/grammar/grammar.ebnf
Outdated
| @@ -29,15 +29,18 @@ item_decl = identifier, break_opt, | |||
| field_decl = identifier, break_opt, ":", break_opt, | |||
| identifier, break_opt, | |||
| field_end; | |||
| custom_union_item_decl = identifier, break_opt, ":", break_opt, | |||
| number, break_opt, | |||
There was a problem hiding this comment.
custom_union_item_decl allow 0 as custom ID, it should be number_greater_or_equal_than_zero here.
Ref:
molecule/tools/codegen/src/grammar.pest
Lines 12 to 13 in 1b3bfe2
molecule/tools/codegen/src/grammar.pest
Lines 31 to 35 in 1b3bfe2
molecule/tools/codegen/src/grammar.pest
Lines 49 to 54 in 1b3bfe2
There was a problem hiding this comment.
thx for the tip, improved
eval-exec
approved these changes
Dec 29, 2023
quake
approved these changes
Dec 29, 2023
yangby-cryptape
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync with this update #65