Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add missing crate features #4736

Merged

Conversation

doitian
Copy link
Member

@doitian doitian commented Dec 3, 2024

Blocking release of v0.120.0

What problem does this PR solve?

Problem Summary: Failed to cargo publish because of missing features listed in Cargo.toml

What is changed and how it works?

What's Changed: See commit messages

Related changes

  • Need to cherry-pick to the release branch rc/v0.120.x

Check List

Tests

  • Manual test (add detailed scripts or steps below)
CKB_PUBLISH_FROM=util/metrics-service devtools/release/publish-crates.sh -n
CKB_PUBLISH_FROM=spec devtools/release/publish-crates.sh -n

Release note

None: Exclude this PR from the release note.

@doitian doitian added the s:blocking Status: This PR must be merged first label Dec 3, 2024
eval-exec
eval-exec previously approved these changes Dec 3, 2024
@doitian doitian force-pushed the bugfix/add-missing-crate-features branch 2 times, most recently from 2dde57f to f7fe331 Compare December 3, 2024 09:13
@doitian doitian force-pushed the bugfix/add-missing-crate-features branch from f7fe331 to 40b3840 Compare December 4, 2024 01:04
@doitian
Copy link
Member Author

doitian commented Dec 4, 2024

Rebased becase I forgot to update Cargo.lock

@doitian doitian marked this pull request as ready for review December 4, 2024 01:05
@doitian doitian requested a review from a team as a code owner December 4, 2024 01:05
@doitian doitian requested review from quake, driftluo and eval-exec and removed request for a team December 4, 2024 01:05
@doitian doitian added this pull request to the merge queue Dec 4, 2024
Merged via the queue into nervosnetwork:develop with commit ac3aa44 Dec 4, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:blocking Status: This PR must be merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants