-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openrpc generator and use JsonSchema to update rpc/readme #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
from
October 11, 2023 17:03
9bdc3de
to
0ced8c2
Compare
chenyukang
force-pushed
the
rpc-openrpc-gen
branch
from
January 29, 2024 05:53
0fa808e
to
8ec791b
Compare
chenyukang
force-pushed
the
rpc-openrpc-gen
branch
7 times, most recently
from
February 2, 2024 02:46
2d37bcd
to
bac7bfb
Compare
eval-exec
previously approved these changes
Feb 2, 2024
chenyukang
force-pushed
the
rpc-openrpc-gen
branch
from
February 2, 2024 02:52
bac7bfb
to
4db433f
Compare
chenyukang
force-pushed
the
rpc-openrpc-gen
branch
from
February 2, 2024 02:53
4db433f
to
663f1cc
Compare
zhangsoledad
previously approved these changes
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 6, 2024
eval-exec
approved these changes
Feb 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4149
Problem Summary:
Our old way of using
rpc.py
to generate document has some compatibility issues, we may need to tweak it when updating to a new version ofrustc
, since the format for HTML fromcargo doc
may change.This PR introduce a way to use
JsonSchema
to generated PRC document.What is changed and how it works?
JsonSchema
for data structures used by rpcckb-rpc-gen
to generaterpc/README.md
openrpc
specs for better dev experienceschemars
, we may need to contribute the patch to upstream, before that we need to use a patched version.What's Changed:
Related changes
owner/repo
:Check List
Tests
Side effects
Release note