BUGFIX: Repair behat tests and Neos9-Beta-10 compatibility #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Tests/Behavior/Features/Bootstrap/FeatureContext.php
|
If I'm not misstaken we now need to adjust the tests to the workspace command change: neos/neos-development-collection#4708 |
|
Yes and that phpstan crashes the ci is also suboptimal |
setting up the sync / async mode is not necessary anymore
Migrated in a similar fashion as the DocumentUriPathProjection here: https://github.com/neos/neos-development-collection/pull/4993/files#diff-2e3df51a3340b51e08cf9d2ba5aade329a8c0e073354c1d5a72e42c3aaf5a127R618 Solves: #76
mhsdesign
changed the title
mhsdesign
commented
Jun 18, 2024
mhsdesign
commented
Jun 18, 2024
| $this->getNodeAddress($event->contentStreamId, $newLocation->coveredDimensionSpacePoint, $descendantOfNode->getNodeAggregateId()), | ||
| $this->contentRepository->id | ||
| ), iterator_to_array($descendantsOfNode)); | ||
| foreach ($event->succeedingSiblingsForCoverage as $interdimensionalSibling) { |
There was a problem hiding this comment.
Migrated in a similar fashion as the DocumentUriPathProjection here:
https://github.com/neos/neos-development-collection/pull/4993/files#diff-2e3df51a3340b51e08cf9d2ba5aade329a8c0e073354c1d5a72e42c3aaf5a127R618
mhsdesign
changed the title
This was fixed with neos/behat#39
mhsdesign
force-pushed
the
task/fixBehatTests
branch
from
5fa05b3 to
5886d3d
Compare
mhsdesign
force-pushed
the
task/fixBehatTests
branch
from
1ecdaba to
325a10c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way how we write behat tests has undergone major changes via
neos/behatand the runtime helpers in Neos as well.For example we use workspace names now and dont block anymore.
Resolves: #76