Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix error with rule configuration #61

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

kdambekalns
Copy link
Member

Follow-up to #52

Fixes an error that slipped in with #52:

```
[ERROR] Expected an instance of this class or to this class among its parents
        "Rector\Core\Contract\Rector\RectorInterface". Got:
        "Neos\Rector\Generic\ValueObject\FusionPrototypeNameAddComment" in
        /…/Packages/Libraries/neos/rector/src/../config/set/contentrepository-90.php
        (which is being imported from "/…/rector.php").
```
Fixes `Uncaught TypeError: count(): Argument #1 ($value)must be of
type Countable|array, null given` when no comments were found.
@kdambekalns kdambekalns requested a review from dlubitz May 14, 2024 12:30
@kdambekalns kdambekalns self-assigned this May 14, 2024
@kdambekalns kdambekalns requested review from kitsunet and mhsdesign May 14, 2024 12:35
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@kdambekalns kdambekalns merged commit e105c8f into main May 14, 2024
2 checks passed
@kdambekalns kdambekalns deleted the bugfix/followup-to-52 branch May 14, 2024 12:47
@dlubitz
Copy link
Contributor

dlubitz commented May 14, 2024

Thanks for taking care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants