Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Prevent copy nodes across dimensions #3892

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

mhsdesign
Copy link
Member

see neos/neos-development-collection#5054 (comment)

Previously the $targetDimensionSpacePoint was also wrongly chosen, and it was attempted to paste the node into the subjects home dimension

Also we hide the paste button in the Neos Ui if its across dimensions (im not sure if this is the best idea but yeah) - maybe an error is better?

What I did

How I did it

How to verify it

see neos/neos-development-collection#5054 (comment)

Previously the `$targetDimensionSpacePoint` was also wrongly chosen, and it was attempted to paste the node into the subjects home dimension
@github-actions github-actions bot added Bug Label to mark the change as bugfix 9.0 labels Dec 7, 2024
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely

@kitsunet kitsunet merged commit f1b2b8a into neos:9.0 Dec 13, 2024
8 of 9 checks passed
@mhsdesign mhsdesign deleted the bugfix/prevent-copy-across-dimensions branch December 14, 2024 14:39
@mhsdesign mhsdesign changed the title BUGFIX: Prevent copy nodes across dimensions BUGFIX: Prevent copy nodes across dimensions Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 Bug Label to mark the change as bugfix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants