Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE Add timeable node visibility #3681

Merged
merged 6 commits into from
Feb 11, 2024
Merged

FEATURE Add timeable node visibility #3681

merged 6 commits into from
Feb 11, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Jan 2, 2024 •
edited
Loading

Adopt UI to use the new properties for the Timeable Node Visibility.

Rename _hiddenBeforeDateTime to enableAfterDateTime and _hiddenAfterDateTime to disableAfterDateTime.

@dlubitz dlubitz added the 9.0 label Jan 2, 2024
mhsdesign
mhsdesign approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to test this probably as i had the feeling it worked already without this change?

mhsdesign
mhsdesign approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked again an now it makes sense after the adjustments

@dlubitz dlubitz marked this pull request as ready for review February 11, 2024 11:55
@neos-bot
Copy link

🎥 End-to-End Test Recordings

These videos demonstrate the end-to-end tests for the changes in this pull request.

@dlubitz dlubitz merged commit 13dccc9 into neos:9.0 Feb 11, 2024
10 checks passed
@dlubitz dlubitz deleted the 90/timeable-node-visibility branch February 11, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees
No one assigned
Labels
9.0
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlubitz @neos-bot @mhsdesign