Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Make long nodetype names readable in the node infoview #3662

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Nov 8, 2023

What I did

Prevent nodetype name from overflowing the node info view.

How I did it

Insert soft hyphens after dots and colons in the nodetype name for the NodeInfoView.
And force word break via CSS and hide browser hyphen character.

How to verify it

Before:

Bildschirmfoto 2023-11-08 um 14 33 54

After:

Bildschirmfoto 2023-11-08 um 14 33 30

@Sebobo Sebobo added Bug Label to mark the change as bugfix 8.3 labels Nov 8, 2023
@Sebobo
Copy link
Member Author

Sebobo commented Nov 8, 2023

Targeting 7.3 caused a conflict mess.

Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix ❤️

@jonnitto jonnitto merged commit b26f24d into 8.3 Nov 8, 2023
3 checks passed
@jonnitto jonnitto deleted the bugfix/nodeinfoview-overflow branch November 8, 2023 19:26
@Sebobo
Copy link
Member Author

Sebobo commented Nov 16, 2023

This actually caused a regression when copying the nodetype name as it now contains the visible hyphens...
Will need to find a better solution.

@jonnitto
Copy link
Member

jonnitto commented Dec 2, 2023

We could add a function to copy it on clipboard on click, wdyt?

@bwaidelich
Copy link
Member

This actually caused a regression when copying the nodetype name as it now contains the visible hyphens

I stumble upon this a lot, especially when copying the node type for a db query because those hyphens are not directly visible always but lead to the db queries to return wrong results :)

As @Sebobo mentioned, this could probably be fixed by using <wbr> instead of \u00AD.
A "copy to clipboard" button would be nice on top :)

@Sebobo
Copy link
Member Author

Sebobo commented Apr 10, 2024

I added a copy to clipboard in my customers project as they have an extended variant of the node info view with improved readability. I can probably transfer both the fix and the button from there (which was anyway my plan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants