Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Apply multiple properties from inspector #3656

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Oct 30, 2023

Resolves #4656

This inverts the UpdateNodeInfo feedback by applying the respective last similar feedback instead of the first, since nodes don't update their internal state any more.

How to verify it

Change two inspector properties at the same time

@mhsdesign mhsdesign requested a review from nezaniel October 30, 2023 14:06
@github-actions github-actions bot added Bug Label to mark the change as bugfix 9.0 labels Oct 30, 2023
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible and works

@nezaniel nezaniel merged commit 15672ed into 9.0 Oct 30, 2023
4 checks passed
@nezaniel nezaniel deleted the bugfix/applyMultiplePropertiesFromInspector branch October 30, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 Bug Label to mark the change as bugfix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants