Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: cleanup node service #3640

Merged
merged 3 commits into from
Oct 16, 2023
Merged

TASK: cleanup node service #3640

merged 3 commits into from
Oct 16, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Oct 12, 2023

i leveraged

$this->contentRepositoryRegistry->subgraphForNode($node)
            ->findClosestNode($node->nodeAggregateId, FindClosestNodeFilter::create(nodeTypeConstraints: NodeTypeNameFactory::NAME_DOCUMENT));

over manually iterating over the parents. Helper methods were inlined in the few places used.
The "NodeService" was renamed to something which seems more internal and should not be used from outside ;)

What I did

How I did it

How to verify it

requires neos/neos-development-collection#4601 to be merged first.

@mhsdesign mhsdesign added the 9.0 label Oct 12, 2023
@github-actions github-actions bot added the Task label Oct 12, 2023
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@mhsdesign mhsdesign merged commit 9dfd8a9 into 9.0 Oct 16, 2023
5 checks passed
@mhsdesign mhsdesign deleted the task/cleanupNodeService branch October 16, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants