Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Show the right error message if only child is published #3634

Merged
merged 7 commits into from
Jun 14, 2024
Merged

BUGFIX: Show the right error message if only child is published #3634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
754c71c
Feature: Add custom error message
pKallert Oct 6, 2023
c72acb0
Merge branch 'neos:9.0' into fix/ShowRightErrorMessages
pKallert Dec 8, 2023
b6f456d
Feature: use domain exception
pKallert Dec 8, 2023
29a73a1
TASK: Improve Exceptionhandling in BackendServiceController
mhsdesign Jan 12, 2024
b41b9d9
Merge branch '9.0' into fix/ShowRightErrorMessages
pKallert Jan 25, 2024
3bfa6b1
Feature: Translate error messages
pKallert Jan 25, 2024
144ec92
FIX: Resolve merge conflict and update with 9.0 branch
pKallert Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Classes/Controller/BackendServiceController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use Neos\ContentRepository\Core\Feature\WorkspaceRebase\Dto\RebaseErrorHandlingStrategy;
use Neos\ContentRepository\Core\Projection\ContentGraph\VisibilityConstraints;
use Neos\ContentRepository\Core\SharedModel\Exception\NodeAggregateCurrentlyDoesNotExist;
use Neos\ContentRepository\Core\SharedModel\Exception\NodeAggregateDoesCurrentlyNotCoverDimensionSpacePoint;
use Neos\ContentRepository\Core\SharedModel\Workspace\WorkspaceName;
use Neos\ContentRepositoryRegistry\ContentRepositoryRegistry;
use Neos\Eel\FlowQuery\FlowQuery;
Expand Down Expand Up @@ -261,9 +262,16 @@ public function publishChangesInDocumentAction(array $command): void
]
]);
} catch (NodeAggregateCurrentlyDoesNotExist $e) {
throw new NodeAggregateCurrentlyDoesNotExist(
'Node could not be published, probably because of a missing parentNode. Please check that the parentNode has been published.',
1682762156
throw new \RuntimeException(
$this->getLabel('NodeNotPublishedMissingParentNode'),
1705053430,
$e
);
} catch (NodeAggregateDoesCurrentlyNotCoverDimensionSpacePoint $e) {
throw new \RuntimeException(
$this->getLabel('NodeNotPublishedParentNodeNotInCurrentDimension'),
1705053432,
$e
);
}
} catch (\Exception $e) {
Expand Down
6 changes: 6 additions & 0 deletions Resources/Private/Translations/en/Main.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,12 @@
<trans-unit id="errorBoundary.footer" xml:space="preserve">
<source>For more information about the error please refer to the JavaScript console.</source>
</trans-unit>
<trans-unit id="NodeNotPublishedMissingParentNode" xml:space="preserve">
<source>Node could not be published, probably because of a missing parentNode. Please check that the parentNode has been published.</source>
</trans-unit>
<trans-unit id="NodeNotPublishedParentNodeNotInCurrentDimension" xml:space="preserve">
<source>Node could not be published, probably because the parentNode does not exist in the current dimension. Please check that the parentNode has been published.</source>
</trans-unit>
<trans-unit id="collapseAll" xml:space="preserve">
<source>Collapse All</source>
</trans-unit>
Expand Down
Loading