Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: improve document title node creation handler #3521

Closed
wants to merge 3 commits into from
Closed

TASK: improve document title node creation handler #3521

wants to merge 3 commits into from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jun 10, 2023 •
edited
Loading

depends on:

neos/neos-development-collection#4324

in Neos 8.3, we could use the NodeUriPathSegmentGenerator::generateUriPathSegment but now we dont have actually the node at hand.

Previously generateUriPathSegment was partially inlined but by creating the lower level helper generateUriPathSegmentFromTextForDimension we can use it again.

@mhsdesign mhsdesign mentioned this pull request Jun 10, 2023
Closed
6 tasks
@mhsdesign mhsdesign changed the base branch from feature/improveNodeCreationHandlerInterface to 9.0 June 10, 2023 20:40
@mhsdesign mhsdesign changed the base branch from 9.0 to feature/improveNodeCreationHandlerInterface June 10, 2023 20:40
@mhsdesign mhsdesign force-pushed the feature/improveNodeCreationHandlerInterface branch 2 times, most recently from bb21d12 to d7b460b Compare June 11, 2023 13:14
@mhsdesign mhsdesign mentioned this pull request Jul 7, 2023
Closed
@mhsdesign mhsdesign force-pushed the feature/improveNodeCreationHandlerInterface branch from 4f9db10 to 00230e3 Compare July 23, 2023 16:32
@mhsdesign
Copy link
Member Author

Outdated

@mhsdesign mhsdesign closed this Aug 1, 2023
@mhsdesign mhsdesign linked an issue Sep 1, 2023 that may be closed by this pull request
re-write NodeTemplates // extend API #3567
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/improveNodeCreationHandlerInterface Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-write NodeTemplates // extend API
1 participant
@mhsdesign