Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! FEATURE: Overhaul
NodeCreationHandlerInterface
#3519!!! FEATURE: Overhaul
NodeCreationHandlerInterface
#3519Changes from all commits
c3dc494
e7a7991
7b751a1
ac5c5fb
258b43c
a9e248c
67b533d
a308ab7
5d26ea2
2e6a225
fa797c9
995c762
0b8cfb4
f9fbf3f
ee15b78
9890e05
96454ff
9847009
5659624
d2db352
366ec92
6f7db58
ea20dc1
563d830
860e9d1
eec2840
9b7c3b1
fd71037
4e12c87
d4c0bf5
554879b
132dbd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if
NodeCreationElements
would implementArrayAccess
and returnValueAccessor
s (as introduced in neos/flow-development-collection#3149). This would allow consumers to write:Otherwise, implementers would have to validate this stuff on their own (and likely in a very similar fashion).
But this is just a nice-to-have 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm i somehow still find the naming and handling of the
ValueAccessors
a little strange and mostly like to validate, or gracefully validate (string cast or no error) which this cannot, on my own.I think we should put the
ValueAccessors
first under a real stress test where we heavily read configuration (like the content repository registry, or the site configuration), so that we can be sure that it is now final api and feature complete ;)But lets discuss this in person as well ;)
Unchanged files with check annotations Beta
Check warning on line 48 in packages/neos-ui-sagas/src/UI/Inspector/index.js
GitHub Actions / Code style