BUGFIX: Lazy-Load focused node, if it's not fully loaded yet #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Feb 14, 2023
markusguenther
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3219
The Problem
CR Node representations in the central Redux store have a flag
isFullyLoadedthat indicates whether the node has been loaded with all of its meta data. If the node has only been loaded for being displayed in the document- or content-tree, this flag is absent, otherwise it is set totrue.The intention behind flag this was to lazy-load the remaining metadata should it become relevant in a specific interaction context. Apparently though, this mechanism has never been implemented.
The Solution
I adjusted the Inspector-saga to perform the aforementioned lazy-load. This fixes #3219, but adds a
plow-jscall, which needs to be kept in mind for #3306.