!!! TASK: Let UI create nodes without nodeName by default

neos · Sep 1, 2023 · c85c241 · c85c241
1 parent ec3ef24
commit c85c241
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Classes/Domain/Model/Changes/AbstractCreate.php b/Classes/Domain/Model/Changes/AbstractCreate.php
@@ -97,9 +97,9 @@ protected function createNode(
         if (is_null($nodeTypeName)) {
             throw new \RuntimeException('Cannot run createNode without a set node type.', 1645577794);
         }
-        // TODO: the $name=... line should be as expressed below
-        // $name = $this->getName() ?: $this->nodeService->generateUniqueNodeName($parent->findParentNode());
-        $nodeName = NodeName::fromString($this->getName() ?: uniqid('node-', false));
+        $nodeName = $this->getName()
+            ? NodeName::fromString($this->getName())
+            : null;
 
         $nodeAggregateId = NodeAggregateId::create(); // generate a new NodeAggregateId