TASK: Fix PromotedElementsCreationHandler to work with new referenc…

…es api
neos · Mar 18, 2024 · a7c94e3 · a7c94e3
1 parent 60b3b10
commit a7c94e3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/...nfrastructure/ContentRepository/CreationDialog/PromotedElementsCreationHandlerFactory.php b/...nfrastructure/ContentRepository/CreationDialog/PromotedElementsCreationHandlerFactory.php
@@ -40,8 +40,7 @@ public function handle(NodeCreationCommands $commands, NodeCreationElements $ele
                 $setReferencesCommands = [];
                 foreach ($elements as $elementName => $elementValue) {
                     // handle properties
-                    // todo this will be simplified once hasProperty does not return true for references
-                    if ($nodeType->hasProperty($elementName) && ($nodeType->getPropertyType($elementName) !== 'references' && $nodeType->getPropertyType($elementName) !== 'reference')) {
+                    if ($nodeType->hasProperty($elementName)) {
                         $propertyConfiguration = $nodeType->getProperties()[$elementName];
                         if (
                             ($propertyConfiguration['ui']['showInCreationDialog'] ?? false) === true
@@ -52,10 +51,9 @@ public function handle(NodeCreationCommands $commands, NodeCreationElements $ele
                     }
 
                     // handle references
-                    // todo this will be replaced by $nodeType->hasReference()
-                    if ($nodeType->hasProperty($elementName) && ($nodeType->getPropertyType($elementName) === 'references' || $nodeType->getPropertyType($elementName) === 'reference')) {
+                    if ($nodeType->hasReference($elementName)) {
                         assert($elementValue instanceof NodeAggregateIds);
-                        $referenceConfiguration = $nodeType->getProperties()[$elementName];
+                        $referenceConfiguration = $nodeType->getReferences()[$elementName];
                         if (
                             ($referenceConfiguration['ui']['showInCreationDialog'] ?? false) === true
                         ) {

diff --git a/Tests/Unit/CreationDialogNodeTypePostprocessorTest.php b/Tests/Unit/CreationDialogNodeTypePostprocessorTest.php
@@ -33,6 +33,7 @@ public function setUp(): void
     public function processCopiesInspectorConfigurationToCreationDialogElements(): void
     {
         $configuration = [
+            'references' => [],
             'properties' => [
                 'somePropertyName' => [
                     'ui' => [
@@ -215,6 +216,8 @@ public function processRespectsEditorDefaultConfiguration(): void
     public function processConvertsCreationDialogConfiguration(): void
     {
         $configuration = [
+            'references' => [],
+            'properties' => [],
             'ui' => [
                 'creationDialog' => [
                     'elements' => [
@@ -307,6 +310,8 @@ public function processConvertsCreationDialogConfiguration(): void
         ]);
 
         $expectedResult = [
+            'references' => [],
+            'properties' => [],
             'ui' => [
                 'creationDialog' => [
                     'elements' => [
@@ -403,6 +408,8 @@ public function processConvertsCreationDialogConfiguration(): void
     public function processDoesNotThrowExceptionIfNoCreationDialogEditorCanBeResolved(): void
     {
         $configuration = [
+            'references' => [],
+            'properties' => [],
             'ui' => [
                 'creationDialog' => [
                     'elements' => [