Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Only reorder NodeAggregateWasRemoved events if the node is not recreated afterwards #5382

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Nov 26, 2024

Currently the Beta16 replay can fail see: https://neos-project.slack.com/archives/C050C8FEK/p1732527086489229

the core problem is outlined in #5363

See https://discuss.neos.io/t/neos-9-beta-16-release/6719/2?u=marc how to apply this patch ;)

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Nov 26, 2024
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and works in the event stream that showed this error.

@mhsdesign mhsdesign marked this pull request as ready for review November 26, 2024 19:39
@mhsdesign mhsdesign changed the title WIP Bugfix: Only reorder NodeAggregateWasRemoved events if the node is not recreated afterwards Bugfix: Only reorder NodeAggregateWasRemoved events if the node is not recreated afterwards Nov 26, 2024
@github-actions github-actions bot added the Bug label Nov 26, 2024
@mhsdesign
Copy link
Member Author

Thanks. Well technically this might still be doomed if you delte a parent and then with the recursive deletion the same problem will occur. But i think its a good step forward and if there are other projections needing an even more sophisticated migration well do it then

@kitsunet
Copy link
Member

I know, but it's better than before and was pretty fast, so lets have it for now.

@kitsunet kitsunet merged commit ebc9f15 into neos:9.0 Nov 27, 2024
10 checks passed
@mhsdesign mhsdesign deleted the bugfix/fix-reorder-nodeaggregate-was-removed-migration branch November 27, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants