BUGFIX: Harden events exporter #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng that the workspace is a base workspace
mhsdesign
commented
Nov 20, 2024
| return new self( | ||
| $event->id->value, | ||
| $event->type->value, | ||
| $payload, | ||
| $event->metadata?->value ?? [], | ||
| $metaData, |
There was a problem hiding this comment.
DISCUSSION: WHY do we export the metadata at all?
There was a problem hiding this comment.
we seem to have done this since ever: eaf246c#diff-6c3b4d67660db1b5b8abed20f90f1018dbc58d0d2b970b0ad34cd75c7f7df855R139
37 tasks
dlubitz
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random-timein export testsUpgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions