-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Throw PartialWorkspaceRebaseFailed
if workspace was up to date and publish didnt work
#5370
Conversation
Shouldn't we merge this for now as a safety measure, not much we can do right now.... |
…information what exactly went wrong The Neos Ui should be able to catch this and tell the user to publish something else first or publish all.
…er-exceptions-if-workspace-was-up-to-date-and-publish-didnt-work
PartialWorkspaceRebaseFailed
if workspace was up to date and publish didnt work
PartialWorkspaceRebaseFailed
if workspace was up to date and publish didnt workPartialWorkspaceRebaseFailed
if workspace was up to date and publish didnt work
Okay i introduced a proper now id say yes merge! The neos ui will still need some love making this a human readable error and also to offer a DiscardAll or PublishAll button (or maybe at some point publishAll parent nodes too ^^) |
Mmmm, the test error seems legit, I'll have a look |
Resolves partially #5364
PartialWorkspaceRebaseFailed
exceptionThrown if the partial publish/discard cannot work because the events cannot be reordered as filtered.
This can happen for cases like attempting to publish a removal first and wanting as remaining change
a node move out of the removed descendants or publishing a node variant creation before the node is created.
We cannot reliably detect these cases in advance but in case the workspace is up-to-date its most likely such
an ordering conflict.
To solve the problem the partial operation should be retried with a different filter or a full publish/discard is required.
If the workspace is outdated we cannot know for sure but suspect first that the conflict arose due to changes
in the base workspace, thus we throw
WorkspaceRebaseFailed
instead.A forced rebase then might not solve the problem if It's because the order of events cannot be changed.
But attempting a second partial publish/discard (with up-to-date workspace) this exception will be thrown and can be reacted upon.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions