-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Unify command and event dispatching in Behat tests #5361
TASK: Unify command and event dispatching in Behat tests #5361
Conversation
...TestSuite/Classes/Behavior/Features/Bootstrap/GenericCommandExecutionAndEventPublication.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 by 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow thanks that was probably a lot of effort :D
@@ -34,11 +34,9 @@ enum RelationDistributionStrategy: string implements \JsonSerializable | |||
case STRATEGY_GATHER_ALL = 'gatherAll'; | |||
case STRATEGY_GATHER_SPECIALIZATIONS = 'gatherSpecializations'; | |||
|
|||
public static function fromString(?string $serialization): self | |||
public static function default(): self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just temporary as we think of making this nullable or introducing and actual Default
here. https://github.com/neos/neos-development-collection/pull/5314/files#diff-4a3a69f0f68fa88f95e6a757f42dee32aa9a14a34ed99433e09a6950b5be0ce1
…ttps://github.com/neos/neos-development-collection into task/unify-behat-test-command-and-event-dispatching
While working on tests for the ContentRepository privileges I realized a couple of inconsistencies with our test suite.
For example:
behaves differently from
because they map to different step implementations.
Furthermore there was a huge amount of duplication and it wasn't easily possible to emit commands from a different source (i.e. from Scenario Outlines)
With this change, command handling is centralized to the
GenericCommandExecutionAndEventPublication
trait and it will allow for writing tests like