-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/centralise rebaseable command enrich with command #5356
Task/centralise rebaseable command enrich with command #5356
Conversation
by only using "official" commands
…therWorkspaceInterface` directly
…ion and get hold of the `$serializedCommand`
neos#5301 (comment) > Alright, at least according to the tests this works now. I also went through all Rebasable commands to check if the events get enriched. the Dimension ones were the only missing. IMHO we should centralize this behavior, I opted against doing it here though as I think we need to consider if there would have to be any more logic involved to decide what gets enriched with commands, in what way, when we override the command if there is already metadata and finally what the causation ids are. I guess we could ignore all these questions and centralize it, but it warrants a closer look and is therefore out of scope of this change.
I found a flaw with Lines 93 to 95 in 76a975d
That would make the API in public function canSerialize(CommandInterface $command): bool;
public function serialize(CommandInterface $command, CommandHandlingDependencies $commandHandlingDependencies): RebasableToOtherWorkspaceInterface; less tidy because we need to allow |
We discussed that centralising the enrichment would be cool, but its also just making "wrong" things pretty :D (see #5348) |
FYI the essence is in 76a975d
#5301 (comment)
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions