TASK: Tests for "Content Repository Privileges" #5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Nov 10, 2024
Neos.Neos/Tests/Behavior/Features/Bootstrap/ContentRepositorySecurityTrait.php
Outdated
Show resolved
Hide resolved
Neos.Neos/Tests/Behavior/Features/Bootstrap/ContentRepositorySecurityTrait.php
Outdated
Show resolved
Hide resolved
Neos.Neos/Tests/Behavior/Features/ContentRepository/Security/EditNodePrivilege.feature
Outdated
Show resolved
Hide resolved
Neos.Neos/Tests/Behavior/Features/ContentRepository/Security/ReadNodePrivilege.feature
Outdated
Show resolved
Hide resolved
…vileges-tests # Conflicts: # Neos.Neos/Tests/Behavior/Features/Bootstrap/WorkspaceServiceTrait.php
…vileges-tests # Conflicts: # Neos.Neos/Tests/Behavior/Features/Bootstrap/WorkspaceServiceTrait.php
Without this fix it was not possible to expect multiple exceptions in a single step or, worse, it led to false positives:
```gherkin
Scenario:
When doing something
Then the last command should have thrown an exception of type "Foo"
When doing something else
Then the last command should have thrown an exception of type "Bar"
```
The 2nd time would succeed even if the previous interaction did not lead to an exception
…once-asserted-in-behat-tests BUGFIX: Behat: Reset `lastCommandException` once asserted
…vileges-tests # Conflicts: # Neos.ContentRepository.TestSuite/Classes/Behavior/Features/Bootstrap/GenericCommandExecutionAndEventPublication.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3732
Related: #5298
Behat tests for #3732