TASK: Document workspace behaviour after partially replaying with pruned content streams #5333
+183
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
commented
Oct 31, 2024
Comment on lines
+242
to
+243
| # FIXME maybe getContentGraph should already throw an exception if the content stream does not exist? | ||
| Then I expect node aggregate identifier "root-node" to lead to no node |
There was a problem hiding this comment.
todo its a little dirty that getContentGraph still works in the detached state (as we just fetch the currentContentStreamId but dont validate that it exists.
its definitely interesting to think about this as catchup hooks will need to deal with this in case youd want to listen to all CreateWorkspace events and get some information at that time from the content graph or the workspace finder ...
There was a problem hiding this comment.
we discussed its not worth to make the query slower just for this case
6 tasks
… null after prune and partial replay see https://neos-project.slack.com/archives/C04PYL8H3/p1730383249323669
mhsdesign
force-pushed
the
task/document-workspace-behaviour-in-detached-state
branch
from
77eac51 to
1d98e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5297
Upgrade instructions
Review instructions
I just discovered a "regression" or rather a behaviour change regarding workspaces. Previously one could always fetch them if they were in the projection. Now with the enhanced status calculation (#5274) because im doing a
joinon the content stream table instead ofleftJoinwe will only get a result if the content stream is also projected.That is most likely the case but when pruning the events from the event store and then only replaying to a certain sequence number i we have the situation of NOT having the content stream joinable.
In https://neos-project.slack.com/archives/C04PYL8H3/p1730383249323669 we discussed that the
nullbehaviour (especially so thatfindWorkspacescontinues to work by only returning the live workspace is the best we can do for now.Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions