TASK: Remove unnecessary double contentstreams #5300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These removed operations in the WorkspacePublishingService doubled up on what happens in the CommandHandler anyways so can be safely removed here.
mhsdesign
requested changes
Oct 19, 2024
There was a problem hiding this comment.
... the thing is by using RebaseWorkspace a RebaseFailed exception will be thrown, which is will required of the Neos.Ui in the future (and probably everyone consuming this api) to display conflict resolution: neos/neos-ui#3769
I believe i discussed that instead of rethrowing the exceptions from the constraint checks in directly, handlePublishIndividualNodesFromWorkspace we need to collect all the failed commands and create a rebasefailed exception.
Though in order to properly test that we need working Neos ui e2e tests that are yet to be fixed: neos/neos-ui#3769
- further one optimisation we can definitely do with BUGFIX 4508 mark dependands of live outdated after direct change #5274 in place is trusting the workspace status and only do a rebase if necessary.
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Oct 26, 2024
…discard as well ... instead of enforcing to rebase from outside. This speeds things up as we need one fork less;) see also neos#5300
|
Will be fixed via #5301 |
6 tasks
neos-bot
pushed a commit
to neos/contentrepository-core
that referenced
this pull request
Oct 28, 2024
…discard as well ... instead of enforcing to rebase from outside. This speeds things up as we need one fork less;) see also neos/neos-development-collection#5300
neos-bot
pushed a commit
to neos/contentrepository-testsuite
that referenced
this pull request
Oct 28, 2024
…discard as well ... instead of enforcing to rebase from outside. This speeds things up as we need one fork less;) see also neos/neos-development-collection#5300
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Oct 28, 2024
…discard as well ... instead of enforcing to rebase from outside. This speeds things up as we need one fork less;) see also neos/neos-development-collection#5300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These removed operations in the WorkspacePublishingService doubled up on what happens in the CommandHandler anyways so can be safely removed here.