Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Fusion eel neos deprecation tracer #5262

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 24, 2024

Requires: neos/flow-development-collection#3386

Related: #4208
Related: #5022

Will by default log as "DEBUG" in development context hints if we use deprecated node field access:

24-09-24 18:39:26 97069      DEBUG                          The Node field "label" is deprecated in "${q(site).property('titleOverride') || site.label}"
24-09-24 18:39:26 97069      DEBUG                          The Node field "label" is deprecated in "${item.label}"
24-09-24 18:39:26 97069      DEBUG                          The Node field "identifier" is deprecated in "${node.identifier}"

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign requested a review from kitsunet October 14, 2024 11:50
@crydotsnake
Copy link
Member

lol

image

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like, thanks!

@mhsdesign mhsdesign requested review from mficzel and dlubitz October 27, 2024 18:42
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me by reading.

But does this make sense, as long as we don't have any replacement for these in 8.4?

@dlubitz
Copy link
Contributor

dlubitz commented Oct 29, 2024

Tests are failing. Maybe a rebase is needed.

@mhsdesign
Copy link
Member Author

Test are always failing on 8.4 :D ...

but you got a point regarding noes 8.4 vs 9.0 .... currently it doesnt look like well have replacements yet and maybe we should only log deprecations then if there is a replacement.... will retarget this pr for 9.0 and down merge that later ggf.

@mhsdesign mhsdesign force-pushed the feature/eelNeosDeprecationTracer branch from a4169e9 to 38099f4 Compare October 30, 2024 14:23
@mhsdesign mhsdesign changed the base branch from 8.4 to 9.0 October 30, 2024 14:23
@github-actions github-actions bot added 9.0 and removed 8.4 labels Oct 30, 2024
@mhsdesign mhsdesign force-pushed the feature/eelNeosDeprecationTracer branch from 38099f4 to 7525dfc Compare October 30, 2024 14:24
@mhsdesign mhsdesign force-pushed the feature/eelNeosDeprecationTracer branch from 7525dfc to 210b5ea Compare October 30, 2024 17:36
@mhsdesign mhsdesign merged commit 38c9a92 into neos:9.0 Oct 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants