BUGFIX: Adjust service templates for references #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These templates are used e.g. in the reference editor, we should create a better endpoint in the UI package, but for now this will fix setting references and provides Fluid users with a viewhelper to render node labels.
nezaniel
approved these changes
Aug 21, 2024
mhsdesign
reviewed
Aug 21, 2024
| @@ -35,4 +35,5 @@ <h1>{neos:backend.translate(id: 'service.nodes.title', value: 'Nodes')}</h1> | |||
| </div> | |||
| </body> | |||
| </html> | |||
| <f:section name="breadcrumb"><f:if condition="{node.parent} && {node.parent.depth} > 1"><f:render section="breadcrumb" arguments="{node: node.parent}" /> > </f:if>{node.label}</f:section> | |||
| <f:section name="breadcrumb"><f:if condition="{node.parent} && {node.parent.depth} > 1"><f:render section="breadcrumb" arguments="{node: node.parent}" /> > </f:if>{neos:node.label(node: node)}</f:section> | |||
There was a problem hiding this comment.
haha there is no node.parent lol :D
There was a problem hiding this comment.
Nope, clearly not, oversight, I can do another fix for that.
There was a problem hiding this comment.
yeah dont worry, #5023 is the full stuff
mhsdesign
reviewed
Aug 28, 2024
| @@ -17,7 +17,7 @@ <h1>{neos:backend.translate(id: 'node', value: 'Node')}: {node.label}</h1> | |||
| </tr> | |||
| <tr> | |||
| <th>_path</th> | |||
| <td class="node-path">{node.path}</td> | |||
| <td class="node-path">{node.name}</td> | |||
There was a problem hiding this comment.
lol were blind. This triggers an error it should be node.name.value
There was a problem hiding this comment.
pushed ... otherwise the ui e2e fail and no beta
mhsdesign
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These templates are used e.g. in the reference editor, we should create a better endpoint in the UI package, but for now this will fix setting references and provides Fluid users with a viewhelper to render node labels.
Fixes partially #5023