!!! TASK: Make kickstart:site command work with Neos 9.0 #5136
Conversation
As the `./flow site:import` command was removed we don't need to generate a `site.xml` anymore.
Relates: neos#4563 Relates: neos/neos-development-collection#4567
|
We briefly talked about the site kickstarter in our last weekly and we might want to do a follow up PR that e.g. includes an import as before. With this PR at least one can create a site package again. |
There was a problem hiding this comment.
Thanks for the adjustments.
I also added php stan level 8 to the site kickstarter codebase so it doesnt rot again ;)
After testing it seems to work, though we dont make use of the site name option by default anymore
./flow kickstart:site <package key> <site name>
There was a problem hiding this comment.
After testing it seems to work, though we dont make use of the site name option by default anymore
Why? I guess it was used in the generated XML, that we no longer have. If it's indeed unused (I suggest one possible place to use it (again), though), we should remove the option!
| 'Neos.Neos:Site': true | ||
| ui: | ||
| icon: globe | ||
| label: '{packageKey} Homepage' |
There was a problem hiding this comment.
This could be the (human-readable) site name, no?
There was a problem hiding this comment.
I would rather remove the option tbh.
ahaeslich
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Review instructions
Run
./flow kickstart:site My.Siteand create a new site based on this package via./flow site:create my-site My.Site My.Site:Document.Homepage.Tested based on our Neos 9 Beta 10 Release.
Related Issue: #4016
Upgrade instructions
Custom packages implementing the
SitePackageGeneratorInterfacewill need to be adjusted as we don't provide thesiteNameanymore.Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions