-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Remove explicit deprecated command blocking #5059
TASK: Remove explicit deprecated command blocking #5059
Conversation
This change was partially ported from neos#4988 Following things have been adjusted: - Removal of the step: The graph projection is fully up to date - remove lastCommandOrEventResult - Removal of the step: The documenturipath projection is up to date - Use injected Connection in tests instead of DoctrineDbalClient (this will be fully refactored in neos#4988)
aea4ff0
to
bba472b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 by 👁️ (with only one eye!)
This is super unrelated :/ |
yes. I agree - and it was somehow unrelated in my large PR, too.. |
yes thats the only part that bums me as well but @bwaidelich started it in his pr and this is a partial fyi. I did a review myself and can confirm that only the stuff that needed to has been removed from the .feature files. |
|
836781b
to
0df9079
Compare
Missing import and no phpstan coverage :D |
This change was partially ported from #4988
Following things have been adjusted:
CommandResult::block
in phpUpgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions