TASK: 4942 - refactor global transformation commands… #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im nearly sure (because of our last conversation) that this is not the case, as they are currently always ever run on the live workspace which we dont rebase. So no need for a migration ;) |
mhsdesign
approved these changes
Apr 4, 2024
|
@bwaidelich @kitsunet we concluded that we are okay with this change so merge it? |
bwaidelich
approved these changes
Apr 5, 2024
mhsdesign
reviewed
Apr 5, 2024
| @@ -114,7 +114,7 @@ public function moveDimensionSpacePointCommand(string $source, string $target, s | |||
|
|
|||
| $contentRepositoryInstance->handle( | |||
| MoveDimensionSpacePoint::create( | |||
| $workspaceInstance->currentContentStreamId, | |||
There was a problem hiding this comment.
we wouldnt event actually need to resolve the workspace instance here but i guess it leads to better errors if we do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to also work with workspaces
Resolves #4942
Upgrade instructions
I think the command structure migration has to be adjusted and re-run, @mhsdesign could you please take care of that?
Review instructions
the global transformations interface has been stripped of the content stream id, because both were implemented as commands that didn't need them. maybe we should keep it for non-command implementations?
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions