TASK: remove obsolete contentStreamId argument for commands in behat #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlubitz
approved these changes
Apr 2, 2024
|
Will merge this as this is a tiny minor cleanup (no behaviour change) and should not block our review capacity, which is currently low |
mhsdesign
deleted the
task/removeObsoleteContentStreamIdArgumentForCommandsInBehat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #4708
The line
And I am in the active content stream of workspace "live" and dimension space point {}will already set the workspaceName to use for the commands. ThecontentStreamIdfield is unused for these commands and will not be used to construct them.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions