Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Homepage should hide uriPathSegment #4826

Merged
merged 2 commits into from
Feb 15, 2024
Merged

TASK: Homepage should hide uriPathSegment #4826

merged 2 commits into from
Feb 15, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jan 12, 2024 •
edited
Loading

Resolves #4621

Neos Ui adjustments: neos/neos-ui#3686

instead of martins suggested solution #4621 (comment) i decided for a simpler and less hacky way: we just hide the property from the inspector but the node technically still has this property: #4563 (comment)

image

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
Copy link
Member Author

As discussed in todays weekly #4621 (comment) we rather want to use a mixin to make sure the property is not existent.

@mhsdesign mhsdesign closed this Jan 12, 2024
@mhsdesign mhsdesign mentioned this pull request Jan 17, 2024
Closed
@mhsdesign
Copy link
Member Author

Reopening as discussed #4621 (comment)

@mhsdesign mhsdesign reopened this Jan 17, 2024
@mhsdesign mhsdesign force-pushed the task/4621–homepage-should-hide-uriPathSegment-in-inspector branch from 626c088 to 663109c Compare February 6, 2024 20:06
@mhsdesign mhsdesign mentioned this pull request Feb 15, 2024
Merged
@kitsunet
Copy link
Member

That branch name....

kitsunet
kitsunet reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok, I guess I won't get my uriPath-less base type :/ sad panda.

@mhsdesign
Copy link
Member Author

yes copy and paste error idk 😂

@mhsdesign mhsdesign merged commit 783e08a into neos:9.0 Feb 15, 2024
10 checks passed
@mhsdesign mhsdesign deleted the task/4621–homepage-should-hide-uriPathSegment-in-inspector branch February 15, 2024 13:36
@bwaidelich bwaidelich changed the title TASK: 4621 Homepage should hide uriPathSegment TASK: Homepage should hide uriPathSegment Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neos.Neos:Site NodeType should not show uriPathSegment property
3 participants
@mhsdesign @kitsunet @bwaidelich